[Macros] Do not edit macro buffer or position when refactoring #64095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnbarham
requested review from
ahoppen,
CodaFi,
DougGregor,
rintaro,
zoecarver,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please test |
bnbarham
commented
Mar 4, 2023
| // ATTACHED_EXPAND-NEXT: 24:3-24:3 (@__swiftmacro_9MacroUser1SV13myTypeWrapperfMA0_.swift) "@accessViaStorage " | ||
| // ATTACHED_EXPAND-NEXT: source.edit.kind.active: | ||
| // ATTACHED_EXPAND-NEXT: 22:11-22:11 (@__swiftmacro_9MacroUser1SV13myTypeWrapperfMm_.swift) " | ||
| // ATTACHED_EXPAND-NEXT: 25:1-25:1 (@__swiftmacro_9MacroUser1SV13myTypeWrapperfMm_.swift) " |
There was a problem hiding this comment.
@DougGregor IMO it's better to match the compiler here (eg. the temporary output) rather than fake it in the refactoring. I'd like to change it when we expand the macro, but I didn't get time to look at the name lookup failure further.
rintaro
reviewed
Mar 4, 2023
Rather than editing the macro buffer in refactoring, add appropriate padding and braces when creating the macro. Don't edit the insertion location - we should update this in a later PR as well.
bnbarham
force-pushed
the
do-not-change-refactoring
branch
from
4ba4a6d to
80d2712
Compare
|
@swift-ci please test |
rintaro
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than editing the macro buffer in refactoring, add appropriate padding and braces when creating the macro.
Don't edit the insertion location - we should update this in a later PR as well.